search

aatxe / irc

the irc crate – usable, async IRC for Rust
Mozilla Public License 2.0
528 stars 97 forks source link

Track actual nickname #125

Closed panicbit closed 4 years ago

panicbit commented 6 years ago

IrcClient::current_nickname currently only reports a nickname from the config. It would make sense to track the actual nick (which could be different from any nick in the config e.g. caused by the server forcing a different nick).

8573 commented 5 years ago

I note that, though commit 0235c71268959f65f7190f52b91ec989355a46b5 may have fixed this issue, that commit seems to have been reverted accidentally.

panicbit commented 4 years ago

Thanks :heart:

8573 commented 4 years ago

Hm, why does GitHub see this as closed by commit 0235c71268959f65f7190f52b91ec989355a46b5 now, "five hours ago", when that commit is over a year old and the latest merge to the main branch (or any branch) is from last year?

panicbit commented 4 years ago

GitHub :heart:

aatxe commented 4 years ago

I was doing some migration to a new machine, and I messed up and advanced develop to the point of 0.14, it seems. On the flip side, I think this might've fixed the mistake I made a while back where I accidentally reverted the commit. So, maybe it's not all bad?

Ep0chalypse commented 2 years ago

It looks like there has been a regression.

I'm using version 0.15.0 and client.current_nickname() returns the nickname from the config file which is not the actual nickname the bot is using. The irc server I'm connecting to is truncating the nickname when I connect.