Closed DoumanAsh closed 5 years ago
Yeah, something strange happened when I merged develop
back into 0.14
. I don't expect 0.14
to drop in the immediate future, but I'll leave this open as a note about fixing it.
@aatxe so for now I shouldn't create PR to remove it? You'd prefer to remove it when 0.14
will be ready?
If you’d like to submit a PR fixing 0.14, that would be appreciated! I’m quite busy until next week is over right now.
Ok, I'll do it on weekend, though I if you're planning further merges from develop branch I might hold on it to avoid getting it lost 😄
Sounds good! Commit 53fb890a7e69d4fa65bba4c07dd46e32e71d3022 might prove useful (or at least the diff for it). That's where I messed it up and the old version before it has the newer tokio stuff.
This was solved in #152.
For some reason it is been added back on 0.14 branch
I believe it is no longer necessary with new tokio? So should be removed?