Clean up tokio-core - Githubissues

aatxe / irc

the irc crate – usable, async IRC for Rust

Mozilla Public License 2.0

528 stars 97 forks source link

Clean up tokio-core #152

Closed DoumanAsh closed 5 years ago

DoumanAsh commented 5 years ago

@aatxe I wonder if I should PR against develop branch rather than 0.14?

aatxe commented 5 years ago

This is a breaking API change. So, 0.14 is the right place. Thanks!

aatxe commented 5 years ago

@DoumanAsh Looks like one of the doctests (the example for IrcClient::new_future) is failing for some reason. I think because it's still being passed the (now non-existent) handle in the example.

DoumanAsh commented 5 years ago

Opps sorry, corrected it

aatxe commented 5 years ago

Okay, everything looks good now! Thanks again! 🍻