search

aatxe / irc

the irc crate – usable, async IRC for Rust
Mozilla Public License 2.0
528 stars 97 forks source link

Add test bot for CI #159

Closed Bassetts closed 5 years ago

Bassetts commented 5 years ago

Fixes #142

@aatxe I have put this in src/bin as I wasn't too sure on the best way to approach this. Obviously the bot doesn't want to be part of the normal tests as it should only run during a CI build, that seems to leave src/examples and src/bin as the two possible places to put this.

Out of the two the bin folder seemed most appropriate as it separates this out from the examples and allows us to run the bot as an individual component during the CI process.

I would really appreciate any feedback on this as I am pretty new to Rust 🙂🦀

aatxe commented 5 years ago

Hi @Bassetts,

Thanks for opening a PR. I looked through the code and it looks great! 😄 It was a good call making it a binary rather than an example, I think. I left just one comment about changing the message (since it'll make it easier for me to read in the future). I'd appreciate if you can make that change, and then I'll merge. But if you can't for whatever reason (time, etc.), let me know.

Cheers!

Bassetts commented 5 years ago

@aatxe my latest commit should format the message to be much more readable. Thanks for the feedback on the PR, it's much appreciated 😄

aatxe commented 5 years ago

Great! Looks good to me, thanks! 🍻