Upgrade tokio-util from 0.2 to 0.3

aatxe / irc

the irc crate – usable, async IRC for Rust

Mozilla Public License 2.0

527 stars 100 forks source link

Upgrade tokio-util from 0.2 to 0.3 #202

Closed tirz closed 4 years ago

8573 commented 4 years ago

Hello,

Your commit message's summary line says that this is a "fix", without further explanation. I suggest adding a commit message body that explains what problem or problems this patch is intended to fix.

(To be clear, I am not a maintainer of this library and am not insisting that you add such explanation.)

tirz commented 4 years ago

In fact, I just had no clue about how to name it according to the conventional commit norm :/ This why I named the branch "dependencies-update_tokio_util" and the commit "fix: upgrade tokio-util from 0.2 to 0.3".

It does not fix any bug, it just adds the necessary refactoring to be able to use the versions "0.3.x".

I may rename it "refactor: upgrade tokio-util from 0.2 to 0.3" ?

aatxe commented 4 years ago

Looks good to me! Cheers!