search

aatxe / irc

the irc crate – usable, async IRC for Rust
Mozilla Public License 2.0
527 stars 100 forks source link

Default ping timeout too low to connect to freenode #207

Closed FauxFaux closed 3 years ago

FauxFaux commented 4 years ago

When connecting to Freenode, from a machine without working reverse dns (like my home), the crate returns a phantom PingTimeout error exactly 10s after start. It appears to have finished connecting, has received the motd and is receiving user modes and the like, but then just PingTimeouts.

Raising the ping_timeout: to Some(20) fixes this; it gives the server enough time to reply to our startup ping (I guess? The sending of pings doesn't seem to be logged.)

Please raise the default ping timeout, and/or have an allowance for starting the ping timeout timer after we are connected; perhaps ignoring the ping/pong (with weird token) some servers do before they send the motd?

aatxe commented 3 years ago

This should've been resolved in #222.