Bump to Tokio 0.3.0 and clean up a few dependencies

aatxe / irc

the irc crate – usable, async IRC for Rust

Mozilla Public License 2.0

533 stars 98 forks source link

Bump to Tokio 0.3.0 and clean up a few dependencies #220

Closed udoprog closed 3 years ago

udoprog commented 3 years ago

Not a ton of changes this release. Definitely not as many as 0.2 🎉

Removed dependencies:

futures-channel
pin-utils - seems to no longer used, and tokio comes with tokio::pin now.

freddyb commented 3 years ago

@tirz, @udoprog: Do you intend to continue with this PR? If not, I'm happy to pick it up. I am hoping to get a tokio-0.3-based irc crate soon :)

udoprog commented 3 years ago

@freddyb yeah. I was waiting for word from @aatxe. I forgot there was one dep that could be removed but figured this was not a blocker.

aatxe commented 3 years ago

Sorry, I think I got blocked on reviewing it because of all the formatting changes, and then failed to get back to it. It looks fine, and I'm happy to accept it. Can you rebase (and feel free to remove the other dependency too)?

udoprog commented 3 years ago

Rebased and put formatting in a single commit at the head.

bytes and bufstream deps are gone.

Github easily lets you filter out the commits you want to see, so the relevant diff can be viewed like this: https://github.com/aatxe/irc/pull/220/files/56e584fe76f788c3430ef1e56a4c795d03946e25..370fb1c0885830e593e78fdc020015c9ee9587eb

aatxe commented 3 years ago

Looks good to me, cheers!

freddyb commented 3 years ago

Thank you, you fine people :rainbow: