aatxe / irc

the irc crate – usable, async IRC for Rust
Mozilla Public License 2.0
535 stars 100 forks source link

[0.9.0] Warnings Beta(1.4) #36

Closed DoumanAsh closed 9 years ago

DoumanAsh commented 9 years ago

Not sure if you already aware of it\or fixed it but here are warnings on current Beta(1.4) for version 0.9.0:

Example:

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26:5: 26:51 warning: the trait `std::io::BufRead` is not implemented for the type `T` [E0277]

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26     fn iter(&'a self) -> ServerIterator<'a, T, U>;

                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26:5: 26:51 help: run `rustc --explain E0277` to see a detailed explanation

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26:5: 26:51 note: this warning results from recent bug fixes and clarifications; it will become a HARD ERROR in the next release. See RFC 1214 for details.

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26     fn iter(&'a self) -> ServerIterator<'a, T, U>;

                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26:5: 26:51 note: required by `client::server::ServerIterator`

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26:5: 26:51 warning: the trait `core::marker::Send` is not implemented for the type `T` [E0277]

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26     fn iter(&'a self) -> ServerIterator<'a, T, U>;

                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26:5: 26:51 help: run `rustc --explain E0277` to see a detailed explanation

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26:5: 26:51 note: `T` cannot be sent between threads safely

/home/travis/.cargo/registry/src/github.com-0a35038f75765ae4/irc-0.9.0/src/client/server/mod.rs:26:5: 26:51 note: this warning results from recent bug fixes and clarifications; it will become a HARD ERROR in the next release. See RFC 1214 for details.

FYI: https://travis-ci.org/DoumanAsh/vndis-rusty-bot/jobs/84440421

aatxe commented 9 years ago

Can you try to use the git build and see if the latest commit (c372403ed585666536b46a6132c6f37eac6556ab) fixes the issue?

DoumanAsh commented 9 years ago

Switched to master, still warnings though a bit less and some different(didn't look into code):

/home/travis/.cargo/git/checkouts/irc-d0a70a664763003b/master/src/client/server/mod.rs:265:1: 266:75 warning: trait bounds are not (yet) enforced in type definitions [E0122]

/home/travis/.cargo/git/checkouts/irc-d0a70a664763003b/master/src/client/server/mod.rs:265 pub type ServerCmdIterator<'a, T: IrcRead + 'a, U: IrcWrite + 'a> =

/home/travis/.cargo/git/checkouts/irc-d0a70a664763003b/master/src/client/server/mod.rs:266     Map<ServerIterator<'a, T, U>, fn(Result<Message>) -> Result<Command>>;

/home/travis/.cargo/git/checkouts/irc-d0a70a664763003b/master/src/client/server/mod.rs:265:1: 266:75 help: run `rustc --explain E0122` to see a detailed explanation

/home/travis/.cargo/git/checkouts/irc-d0a70a664763003b/master/src/client/server/mod.rs:26:5: 26:51 warning: the trait `std::io::BufRead` is not implemented for the type `T` [E0277]

/home/travis/.cargo/git/checkouts/irc-d0a70a664763003b/master/src/client/server/mod.rs:26     fn iter(&'a self) -> ServerIterator<'a, T, U>;

https://travis-ci.org/DoumanAsh/vndis-rusty-bot/jobs/84550186

I think you can also setup travis for this repo. By default it will first run cargo build --verbose and after that cargo test --verbose So even though there are no tests you can still verify your builds :)

P.s. didn't notice that you already have travis setup :)

aatxe commented 9 years ago

Yeah, I thought Travis was using stable, but it's not. I realized I was also using stable locally. So, I switched to nightly to check this out.