search

aatxe / irc

the irc crate – usable, async IRC for Rust
Mozilla Public License 2.0
530 stars 97 forks source link

Update openssl to 0.9.10 #79

Closed Manishearth closed 7 years ago

Manishearth commented 7 years ago

r? @aatxe

cc @sfackler

aatxe commented 7 years ago

Doesn't this change behavior in a multithreaded situation? That is if you have a reading thread, a separate writing thread will wait forever? I believe some situation like this was why I split the reader and writer originally.

cc @retep998 (who bugged me about this in the first place)

Manishearth commented 7 years ago

@sfackler was asking about this on IRC -- if it was duplexed or not. I guess it is?

Manishearth commented 7 years ago

We should probably figure something out here soon, currently this library is totally broken if someone wants to use hyper as well (you can't have multiple versions of native libs in your deps)

aatxe commented 7 years ago

Agreed. My intention was to handle this while I changed the library to be asynchronous but when I was trying, I couldn't quite figure out a good interface to expose.

qlyoung commented 7 years ago

What's the status on this? Still broken with hyper. Love the library but if this patch fixes things perhaps you could take it and patch later?

aatxe commented 7 years ago

Well, I suppose I don't have a good sense of how people are using the library, but there's a reasonable chance that this would be a very serious breakage. You won't be able to send messages while waiting to receive a message. You'll only be able to send responses following a received message.

aatxe commented 7 years ago

@Manishearth I decided to go ahead with this anyway, but committed it manually with --author (because of drift). I think the duplexing is not likely to be much of an issue for the average user. So, as @qlyoung suggested, we can fix the new problem later.

The commit is 02f9968b0cdc2754a0659bcd9f83fc5e2c5cd736.

Manishearth commented 7 years ago

Awesome, thanks!