aatxe / irc

the irc crate – usable, async IRC for Rust
Mozilla Public License 2.0
530 stars 97 forks source link

IRC crate incorrectly interprets an ISUPPORT message as a BOUNCE message #87

Closed sector-f closed 7 years ago

sector-f commented 7 years ago

According to this page (which, according to Havvy on the #rust IRC channel, "should be considered for all intents and purposes the living IRC specification"), 005 is RPL_ISUPPORT.

This crate incorrectly interprets 005 as RPL_BOUNCE. 005 was formerly RPL_BOUNCE, but that has been moved to 010.

To fix this issue:

For reference, here are the two ISUPPORT messages I received from Rizon's IRC server when connecting to it:

:solenoid.rizon.net 5 ircfs CALLERID CASEMAPPING=rfc1459 DEAF=D KICKLEN=180 MODES=4 PREFIX=(qaohv)~&@%+ STATUSMSG=~&@%+ EXCEPTS=e INVEX=I NICKLEN=30 NETWORK=Rizon MAXLIST=beI:250 MAXTARGETS=4  :are supported by this server
:solenoid.rizon.net 5 ircfs CHANTYPES=# CHANLIMIT=#:500 CHANNELLEN=50 TOPICLEN=390 CHANMODES=beI,k,l,BCMNORScimnpstz WATCH=60 NAMESX UHNAMES AWAYLEN=180 ELIST=CMNTU SAFELIST KNOCK :are supported by this server
aatxe commented 7 years ago

Thanks, good catch!