aau-cns / mars_ros

A ROS wrapper for the MaRS Library
Other
56 stars 12 forks source link

[Question] Why don't we call MarsWrapperGps::RunCoreStatePublisher() in MarsWrapperGps::ImuMeasurementCallback(...) #2

Closed dantenoguera closed 2 years ago

dantenoguera commented 2 years ago

Hi! As the title says shoudn't this:

https://github.com/aau-cns/mars_ros/blob/834ad792a5f62565cf8869cab7db2c8d491d2093/src/mars_wrapper_gps.cpp#L164-L172

be like this:

https://github.com/aau-cns/mars_ros/blob/834ad792a5f62565cf8869cab7db2c8d491d2093/src/mars_wrapper_pose.cpp#L168-L171

Chris-Bee commented 2 years ago

Hello @dantenoguera, that's a very good idea. Our internal version already has this modification among other features and improvements. This will go online by this week, together with the open-sourcing of our flight stack code (See the paper FYI: https://ieeexplore.ieee.org/document/9849131).

Chris-Bee commented 2 years ago

@dantenoguera as mentioned above, the changes you mentioned have been part of our latest development stage and are now present in the development branch. Hope this helps.

dantenoguera commented 2 years ago

Awesome