aau-giraf / api_client

API client for Flutter to communicate with the web-api

GNU General Public License v3.0

6 stars 0 forks source link

Offline db error handing #108

Closed makelblack159 closed 2 years ago

makelblack159 commented 2 years ago

val and val length

edit length val and local val and fixed the test so they did expect the right values instead of nulls. removed weekcolorupdate because offline database doesn't need it for it to remove error will come another update to it so that works too

Type of change

Delete unchecked boxes (only for Type of change)

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

codecov[bot] commented 2 years ago

Codecov Report

Merging #108 (6ee8adb) into develop (9ab1746) will decrease coverage by 0.1%. The diff coverage is 0.0%.

@@            Coverage Diff            @@
##           develop    #108     +/-   ##
=========================================
- Coverage     69.2%   69.1%   -0.2%     
=========================================
  Files           44      44             
  Lines         1013    1015      +2     
=========================================
  Hits           702     702             
- Misses         311     313      +2

Impacted Files	Coverage Δ
lib/offline_database/offline_db_handler.dart	`45.6% <0.0%> (-0.5%)`	:arrow_down:

manfredhod commented 2 years ago

Laver i ikke helt de samme ændringer i #109 ? Hvis jeg sammenligner de to filer i de branches er de 100% identiske.

makelblack159 commented 2 years ago

Laver i ikke helt de samme ændringer i #109 ? Hvis jeg sammenligner de to filer i de branches er de 100% identiske.

jo men skulle havde det med i den nye da jeg arbejder med det men kan ikke gøre noget ved denne ikke er blevet accepteret endnu og da jeg ikke ventede begyndte jeg at lave vidre på det