aau-giraf / api_client

API client for Flutter to communicate with the web-api
GNU General Public License v3.0
6 stars 0 forks source link

Settings for weekplanner571 #119

Closed Lildhansen closed 1 year ago

Lildhansen commented 2 years ago

This is a copy of this Pull request, which had to be reverted until the weekplanner had been updated. The weekplanner has now been updated in this Pull request

Description

necessary for work done on this branch: Expanded settings model to make 2 variables for handling the number of days to display in a weekplanner: a variable for the days to display in portrait mode and one for the days to display in landscape mode.

Since we changed the name of the variable nrOfDaysToDisplay, this will cause errors on the weekplanner, but to fix this we simply need to change the variable name of the weekplanner repository as well as the columns of the settings database

Also added a bool defining if days shown should start from today (relative) or Monday (absolute)

Also commented out a test dealing with offline mode, since it has been decided to ignore offline mode Related to #571 of weekplanner

Type of change

Delete unchecked boxes (only for Type of change)

How Has This Been Tested?

This has only been unit tested using flutter test --coverage

Development Configuration Type "flutter --version" and "dart --version" in your CMD to check versions.

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #119 (d9e0deb) into develop (1d3c1bf) will decrease coverage by 4.7%. The diff coverage is 27.5%.

@@            Coverage Diff            @@
##           develop    #119     +/-   ##
=========================================
- Coverage     69.2%   64.4%   -4.8%     
=========================================
  Files           44      44             
  Lines         1030    1041     +11     
=========================================
- Hits           713     671     -42     
- Misses         317     370     +53     
Impacted Files Coverage Δ
lib/offline_database/offline_db_handler.dart 32.3% <0.0%> (-15.3%) :arrow_down:
lib/models/settings_model.dart 62.5% <50.0%> (-35.6%) :arrow_down: