aau-giraf / api_client

API client for Flutter to communicate with the web-api

GNU General Public License v3.0

6 stars 0 forks source link

Issue 633 #126

Closed mariusgardshodn closed 1 year ago

mariusgardshodn commented 1 year ago

Description

The baseUrl for the HttpClient regarding the AccountApi in api.dart has been changed, since the URL, while fixing issue 633 in weekplanner, doubled the former baseUrl.

Fixes #633

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

How Has This Been Tested?

No tests since this is a small bug fix

Development Configuration

Flutter version: Flutter 2.0.5
Dart version: Dart SDK version: 2.12.3

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas, if necessary
[] I have made corresponding changes to the documentation, if necessary
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works, if necessary
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have Acceptance Tested this on an iOS device
[ ] I have Acceptance Tested this on an Android device

codecov[bot] commented 1 year ago

Codecov Report

Merging #126 (e78e3fe) into develop (74d2222) will increase coverage by 0.7%. The diff coverage is 55.2%.

@@            Coverage Diff            @@
##           develop    #126     +/-   ##
=========================================
+ Coverage     69.3%   70.1%   +0.7%     
=========================================
  Files           44      44             
  Lines         1048    1054      +6     
=========================================
+ Hits           727     739     +12     
+ Misses         321     315      -6

Impacted Files	Coverage Δ
lib/api/api.dart	`0.0% <0.0%> (ø)`
lib/api/user_api.dart	`61.4% <61.3%> (+1.4%)`	:arrow_up:
lib/offline_database/offline_db_handler.dart	`50.0% <61.7%> (+2.3%)`	:arrow_up: