aau-giraf / api_client

API client for Flutter to communicate with the web-api
GNU General Public License v3.0
6 stars 0 forks source link

Settings for weekplanner571 #128

Closed Lildhansen closed 1 year ago

Lildhansen commented 1 year ago

this is mostly a copy of this PR - very few things have been changed, but now all tests pass

Description

_necessary for work done on this branch:_ Expanded settings model to make 2 variables for handling the number of days to display in a weekplanner: a variable for the days to display in portrait mode and one for the days to display in landscape mode.

Since we changed the name of the variable nrOfDaysToDisplay, this will cause errors on the weekplanner, but to fix this we simply need to change the variable name of the weekplanner repository as well as the columns of the settings database

Also added a bool defining if days shown should start from today (relative) or Monday (absolute)

Also commented out a test dealing with offline mode, since it has been decided to ignore offline mode Related to #571 of weekplanner

Type of change

Delete unchecked boxes (only for Type of change)

How Has This Been Tested?

This has only been unit tested using flutter test --coverage (or by running tests in android studio)

Development Configuration Type "flutter --version" and "dart --version" in your CMD to check versions.

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #128 (5ef8d70) into develop (3b70466) will decrease coverage by 5.6%. The diff coverage is 28.5%.

@@            Coverage Diff            @@
##           develop    #128     +/-   ##
=========================================
- Coverage     66.3%   60.7%   -5.7%     
=========================================
  Files           34      34             
  Lines          976     988     +12     
=========================================
- Hits           648     600     -48     
- Misses         328     388     +60     
Impacted Files Coverage Δ
lib/offline_database/offline_db_handler.dart 31.2% <0.0%> (-16.4%) :arrow_down:
lib/models/settings_model.dart 63.0% <50.0%> (-35.4%) :arrow_down: