mikejensen0 commented 2 years ago

Description

The AccountController integration test failed because the UserController was missing request handling, which previously existed, but was removed in a refactor in pr#241. We assume that they forgot to re-add the request handling. This has been added and works on my machine.

Fixes #279

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The integration tests were run locally. This was done in both the feature branch and in the develop branch to see that no other tests would start failing.

Development Configuration

Dotnet version: 6.0.401

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas, if necessary
[x] I have made corresponding changes to the documentation, if necessary
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works, if necessary
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[ ] I have Acceptance Tested this on an iOS device
[ ] I have Acceptance Tested this on an Android device

ltranu20 commented 2 years ago

I was able to run the tests and all 26 of them passed

What about that big, fat error at the top that completely breaks unit tests?

Taoshix commented 2 years ago

I was able to run the tests and all 26 of them passed

What about that big, fat error at the top that completely breaks unit tests?

That is related to #281 and the UserController while this PR was about the AccountController

manfredhod commented 2 years ago

I was able to run the tests and all 26 of them passed

What about that big, fat error at the top that completely breaks unit tests?

That is related to #281 and the UserController while this PR was about the AccountController

They change the UserController in the PR therefore, the unit tests have to be updated so they don't fail.

mikejensen0 commented 2 years ago

I was able to run the tests and all 26 of them passed

What about that big, fat error at the top that completely breaks unit tests?

That is related to #281 and the UserController while this PR was about the AccountController

They change the UserController in the PR therefore, they have to update the unit tests too so they don't fail.

@manfredhod @ltranu20 That is our mistake. I have made a pr for reverting the merge: https://github.com/aau-giraf/web-api/pull/292

aau-giraf / web-api

Fixed AccountController Integration test #290

Description

Type of change

How Has This Been Tested?

Checklist: