Integrations tests should not run on every commit.

aau-giraf / web-api

The backend API for GIRAF — a .NET-core project written in C#.

GNU General Public License v3.0

2 stars 5 forks source link

Integrations tests should not run on every commit. #300

Closed Just1Per closed 11 months ago

Just1Per commented 1 year ago

Integration test (maybe unit test?) should only run in our CI pipeline when making PR to the develop branch and not on every commit. This should be done to save compute time from GitHub Actions.

Potential solutions: Go to the file: repo/.github/workflows/*.yml Change the “on” command to only run on pull request to the develop branch Investigate if test should/how they could run when deploying aswell

ltranu20 commented 1 year ago

It would not affect nor speed up anything. Accounts can have up to 20 concurrent jobs (40 if pro), meaning the bottleneck is GitHub.

andreaskrath commented 11 months ago

This issue a non-issue, branch protection prevents direct commits to development meaning this is no longer a concern.