aau-giraf / web-api

The backend API for GIRAF — a .NET-core project written in C#.
GNU General Public License v3.0
2 stars 5 forks source link

Task/319 #320

Closed andreaskrath closed 11 months ago

andreaskrath commented 11 months ago

Description

311 and #317 should be merged before this pull request is reviewed.

Removes all unused dependencies any of the three libraries GirafRest, GirafRest.Test, and GirafRest.IntegrationTest, also update the deprecated packages with obvious alternatives.

Even though there are some NuGet packages that do not have a direct code dependency right now, they have been deliberately left as they deal with code coverage, code analysis and the like.

Fixes #319

I have chosen to purposefully branch from an un-accepted and un-merged branch in task/317 the reason for this is simply because updating dependencies on the old .NET version would be meaningless if any of the changes I made (as a I updated a few deprecated packages) would not work on the updated .NET version.

Type of change

This change does not fit under any of the pre-defined boxes.

How Has This Been Tested?

Going one library at a time I have:

  1. Removed a NuGet package
  2. Rebuild solution
  3. Ran unit tests
  4. Ran integration tests

If any of these steps failed along the way, I would re-install the NuGet package and move on. If all steps were completed with all test cases passing, the NuGet package would not be re-installed.

I have tested this on: Linux Kernel 6.1.55 with NixOS 23.11pre528952.6500b4580c2a (Tapir) x86_64 on .NET version 8.0.100-preview.5.23303.2

Checklist:

Outside of the boxes I have checked, none of the other boxes are even relevant to this particular change.

andreaskrath commented 11 months ago

Gustas siger det virker, men fix lige jeres merge conflicts næste gang :)

Der var ikke nogen merge conflicts da jeg åbnede pull requesten så antager de er kommet som følge af merges ind i develop - men vi skal nok lige få ordnet de conflicts.