aau-giraf / weekplanner

Main repository of the Weekplanner tablet application
GNU General Public License v3.0
15 stars 3 forks source link

Issue942 #965

Closed Thuyhaile closed 11 months ago

Thuyhaile commented 1 year ago

Description

The 'Videre' button is only used when generating the pictogram code for 'Borger' in the 'Ny bruger' UI. However, when a user adds a new user (pædagog, værge, borger) with regular code, the 'Videre' button still appears, even though it is not used. Similarly, when the user creates the pictogram code, the 'Gem bruger' button becomes redundant. This can be confusing for the user. image

Fixes #<942> Possible suggested solution: The 'Videre' button is disabled when the user adds a new user (pædagog, værge, borger) and creates regular code, and it becomes enabled when the user is creating pictogram code for 'Borger'. During this time, the 'Gem bruger' button is also disabled. image

Type of change

How Has This Been Tested?

Android Platform: emulation is carried out using Android Studio on Windows computer iOS Platform: emulation is carried out using Xcode on MacBook

Development Configuration

Flutter version: 3.3.8 Dart version: 2.18.4

Checklist:

Thuyhaile commented 12 months ago

Hej, Jeg har løst konflikterne. I kan fortsætte med at gennemgå denne issue.

codecov[bot] commented 11 months ago

Codecov Report

Merging #965 (133e166) into develop (a8daa76) will decrease coverage by 48.7%. Report is 8 commits behind head on develop. The diff coverage is 34.6%.

:exclamation: Current head 133e166 differs from pull request most recent head 72c3b67. Consider uploading reports for the commit 72c3b67 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #965 +/- ## ========================================== - Coverage 78.5% 29.8% -48.7% ========================================== Files 86 47 -39 Lines 4988 2383 -2605 ========================================== - Hits 3918 712 -3206 - Misses 1070 1671 +601 ``` | [Files](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf) | Coverage Δ | | |---|---|---| | [lib/blocs/choose\_citizen\_bloc.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL2Jsb2NzL2Nob29zZV9jaXRpemVuX2Jsb2MuZGFydA==) | `60.0% <100.0%> (ø)` | | | [lib/blocs/copy\_resolve\_bloc.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL2Jsb2NzL2NvcHlfcmVzb2x2ZV9ibG9jLmRhcnQ=) | `100.0% <100.0%> (ø)` | | | [lib/blocs/new\_pictogram\_password\_bloc.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL2Jsb2NzL25ld19waWN0b2dyYW1fcGFzc3dvcmRfYmxvYy5kYXJ0) | `92.3% <100.0%> (ø)` | | | [lib/widgets/bottom\_app\_bar\_button\_widget.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL3dpZGdldHMvYm90dG9tX2FwcF9iYXJfYnV0dG9uX3dpZGdldC5kYXJ0) | `0.0% <ø> (-100.0%)` | :arrow_down: | | [lib/widgets/loading\_spinner\_widget.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL3dpZGdldHMvbG9hZGluZ19zcGlubmVyX3dpZGdldC5kYXJ0) | `11.1% <ø> (-77.8%)` | :arrow_down: | | [lib/blocs/auth\_bloc.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL2Jsb2NzL2F1dGhfYmxvYy5kYXJ0) | `0.0% <0.0%> (-28.0%)` | :arrow_down: | | [...widgets/choiceboard\_widgets/choice\_board\_part.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL3dpZGdldHMvY2hvaWNlYm9hcmRfd2lkZ2V0cy9jaG9pY2VfYm9hcmRfcGFydC5kYXJ0) | `0.0% <0.0%> (-71.5%)` | :arrow_down: | | [lib/widgets/giraf\_activity\_time\_picker\_dialog.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL3dpZGdldHMvZ2lyYWZfYWN0aXZpdHlfdGltZV9waWNrZXJfZGlhbG9nLmRhcnQ=) | `0.0% <0.0%> (-96.4%)` | :arrow_down: | | [lib/widgets/timer\_widgets/timer\_countdown.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL3dpZGdldHMvdGltZXJfd2lkZ2V0cy90aW1lcl9jb3VudGRvd24uZGFydA==) | `0.0% <0.0%> (ø)` | | | [lib/widgets/timer\_widgets/timer\_piechart.dart](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf#diff-bGliL3dpZGdldHMvdGltZXJfd2lkZ2V0cy90aW1lcl9waWVjaGFydC5kYXJ0) | `0.0% <0.0%> (-100.0%)` | :arrow_down: | | ... and [28 more](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf) | | ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/aau-giraf/weekplanner/pull/965/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aau-giraf)