aau-network-security / haaukins-store

New haaukins component responsible to store data into the database
https://docs.haaukins.com
GNU General Public License v3.0
0 stars 3 forks source link

Feature/add booking helper #000 #27

Closed mrtrkmn closed 4 years ago

mrtrkmn commented 4 years ago
mrtrkmn commented 4 years ago
* Too many logs in the functions `GetEventStatus`, `SetEventStatus`.

* Closing event function dosent work well (it dosent return any error) but from the store you can see (SS) that it creates another row in the DB and moreover the `finished_at` time didn't change
  ![Screenshot from 2020-07-04 14-15-22](https://user-images.githubusercontent.com/55431233/86512270-dde0dc00-be00-11ea-9d4b-f0031c2b7958.png)

I can not understand the meaning of changing the event tag of the event......

i like the timeline feature and its working well but apart from that i don't like the modification you made.

You did not understand it, maybe the reason of that is, you did NOT pay attention what I wrote on slack, issues, pull requests, on code etc. @gianmarcomennecozzi

gianmarcomennecozzi commented 4 years ago

Hmm yeah maybe i didn't understand what you said in slack. But if you want to keep the function that change the event tag there are some stuff to change anyway cause it's working but not as expected i think