Closed mrtrkmn closed 2 years ago
It is not a best practice to see some port numbers bind into binary. It would be ideal to get all values which might be changed env to env from a configuration file. This issue is opened by considering this gRPC port value https://github.com/aau-network-security/haaukins/blob/c4e1f948bb496efaa9cfca1f517b104a6ffec2e6/daemon/daemon.go#L58 but this is not limited to only that value, anything which is better to take it from config file should be introduced.
It is not a best practice to see some port numbers bind into binary. It would be ideal to get all values which might be changed env to env from a configuration file. This issue is opened by considering this gRPC port value https://github.com/aau-network-security/haaukins/blob/c4e1f948bb496efaa9cfca1f517b104a6ffec2e6/daemon/daemon.go#L58 but this is not limited to only that value, anything which is better to take it from config file should be introduced.