search

aau-network-security / haaukins

A Highly Accessible and Automated Virtualization Platform for Security Education
https://general.haaukins.com
Apache License 2.0
187 stars 39 forks source link

Changed markdown parser to as markdown didnt match gitlab. #721

Open Mikkelhost opened 2 years ago

Mikkelhost commented 2 years ago

Changed markdown renderer, apparently old renderer was not CommonMark compliant. So the mark down parsed from readme on gitlab did not look the same in the webclient.

eyJhb commented 2 years ago

Reconsider if it makes sense to use bluemonday at all, since you're already taking "trusted" input, ie. not user specified input. Doesn't seem to make sense to use Goldmark with unsafe HTML, and then try to sanitize it afterwards.

Mikkelhost commented 2 years ago

Reconsider if it makes sense to use bluemonday at all, since you're already taking "trusted" input, ie. not user specified input. Doesn't seem to make sense to use Goldmark with unsafe HTML, and then try to sanitize it afterwards.

I think when i created this i pretty much went from a zero trust perspective. And i think it is a good idea to keep it as a zero trust. For the goldmark with unsafe html, i will take a look, i havn't really done anything else thank making it work :)