add missing test case - Githubissues

aau-network-security / richkit

Domain Enrichment Toolkit $ pip install richkit

https://pypi.org/project/richkit/

MIT License

11 stars 3 forks source link

Closed mrtrkmn closed 4 years ago

mrtrkmn commented 4 years ago

missing test case added however it has no affect to coverage result.
I have checked anaylse.py and apparently, all testable functions are tested.
As seen in given SS below, %73 lines already covered which means, test case visited %73 of analyse.py file, the rest belongs to skipped test cases.

I could not entirely understand why it is %51 in Test with pytest step over here

mrtrkmn commented 4 years ago

New branch called reactivate-test-cases contains following changes:

Skipped tests are revisited and re-implemented here 0c05604
Skipped PTR and A records activated here 042795e
Number of error on Flake changed and some folders excluded in this commit be6dce0
Whois test case added however it does not work on CI however it works on local, here is SS

Drawback of activating tests which use Alexa Top 1 domains, is that tests take much longer than expected approximately 13 minutes.