Random test failures due to crt.sh

aau-network-security / richkit

Domain Enrichment Toolkit $ pip install richkit

https://pypi.org/project/richkit/

MIT License

11 stars 3 forks source link

Random test failures due to crt.sh #132

Open kidmose opened 4 years ago

kidmose commented 4 years ago

We see test errors comming and going intermittently in richkit.retrieve.cert_sh and richkit.retrieve.ctlogs, apparently because www.crt.sh is unreliable.

This has negative impact on how useful the unittesting is.

The fix seems to be to do away with the current bad practice of testing against a live API (Bad for exactly this reason).

kidmose commented 4 years ago

Assigning you, @gianmarcomennecozzi , as I believe you are on your way with a fix (change tests to use a mock server, insted of the live API)