search

aau-zid / BigBlueButton-liveStreaming

Streams a given BBB Meeting to an RTMP Server.
GNU General Public License v3.0
200 stars 159 forks source link

BBB 2.4-rc7: Change needed to be able to run #145

Closed PhMemmel closed 2 years ago

PhMemmel commented 2 years ago

Due to changes in the latest BBB HTML5 client we need to adapt something here:

https://github.com/aau-zid/BigBlueButton-liveStreaming/blob/58ef7941e46e506d37f6d678e949412cc1aa96eb/stream.py#L161

We need to change User list to Users list here and everything runs fine again when building a docker image with this custom change.

mtsonline commented 2 years ago

thanks Pypo, would you provide the change as PR? cheers

PhMemmel commented 2 years ago

Wasn't sure about if we have separate branches for backwards compatibility to 2.3 or sth, but if not - I can provide PR for master soon, sure

mtsonline commented 2 years ago

may you have a look at one of the last prs - there was an example with an if, that allowed for backwardscompatibility. ;-) Hope this should work for this one too, so we can keep one version for 2.3 and 2.4 versions.

PhMemmel commented 2 years ago

Alright :-)