search

aau-zid / BigBlueButton-liveStreaming

Streams a given BBB Meeting to an RTMP Server.
GNU General Public License v3.0
201 stars 160 forks source link

Fix default locale setting #90

Closed thifranc closed 3 years ago

thifranc commented 4 years ago

This pull request adds a 'locale' setting for Chrome webDriver, which is 'en_US.UTF-8'.

This parameter is needed as some of the following code is relying on 'hard coded' english parameters ( ex : css selector "Send message" ). I've also added just a lint about a variable which had a typo in it ( according to me so I may be wrong ).

This PR fixes #89 , opened by me and misunderstood at the beginning.

mtsonline commented 4 years ago

Hi, thanks for your PR. Would you mind to have another look at the code / source and try to remove the requirement for english? I already removed hardcoded english strings and replaced the selenium search by other tags used in the html code of bbb. Maybe you can find tags that won't related to the language.

The problem with the english strings is, that people in the past already had removed english language completely on their bbb instances. If there is no english language available at all, setting the language to english in chrome would not help.

So your fix is great, but it would help even more if the english strings could be removed and be replaced with other tags.

cheers