search

aaubry / YamlDotNet

YamlDotNet is a .NET library for YAML
MIT License
2.48k stars 466 forks source link

Add support for including types defined in another assembly in static code generation #852

Closed prochnowc closed 9 months ago

prochnowc commented 9 months ago

This PR adds a second constructor to the YamlSerializableAttribute to allow static code generation for types defined in another assembly.

Fixes issue #851

EdwardCooke commented 9 months ago

I like this approach, this is nice. The only comment is about the null propagation compiler warning. Once that's resolved, I'll merge this in.

prochnowc commented 9 months ago

Glad that you like it.

When do you plan the next release including this feature ?

EdwardCooke commented 9 months ago

In about 2 minutes, have to let the pipelines finish :)

aaubry commented 9 months ago

This feature has been released in version 13.5.0.

EdwardCooke commented 9 months ago

It takes a couple of minutes for NuGet to approve the package but it will be there momentarily.

prochnowc commented 9 months ago

Sure. Thanks for accepting the feature/PR.

prochnowc commented 9 months ago

@EdwardCooke there is one change missing which I accidently did not commit: https://github.com/aaubry/YamlDotNet/pull/853