code review

[aaur0]

The app is now ready for review /cc: @codepath @codepathreview

[codepathreview]

Nice work finishing all required stories, consider adding more optionals to get the most out of the assignments. A few notes after checking out the code:

• Properly used spinners (with populated values) to allow users to select filters
• Properly sent and received relevant filters using a bundle to pass data between activities
• Correctly named packages and organized source files
• Consider using a single base method loadMoreData() in search activity to fetch results for both initial load and the pagination
• Consider using the ViewHolder pattern to improve performance of photos ListView.
• Consider adding the share intent to the image detail view!
• Consider using Parcelable instead of Serializable (benefits)
• Consider moving the search field into the ActionBar using a custom ActionBar layout or with a SearchView
• Consider adding progress bars to your app whenever a network request goes out

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.