search

aavanzyl / ngx-tiny

Implementation of Light Weight Angular Components for Production Applications
https://aavanzyl.github.io/ngx-tiny
MIT License
7 stars 3 forks source link

Fatal typo on project home page #4

Closed aunkrig closed 4 years ago

aunkrig commented 4 years ago

https://aavanzyl.github.io/ngx-tiny/project/date-picker says:

To install this library, run:
npm install @ngx-tiny/ngx-date-picker --save

That produces a 404. The correct command line is

npm install @ngx-tiny/date-picker --save
jonathan-chin commented 4 years ago

can confirm. was trying to install this and luckily I checked the issues here.

edit: another typo on the styling tab: ./node_modules/ngx-date-picker/theme.scss should be ~@ngx-tiny/date-picker/theme.scss

it's also important to note that the variables should be set before importing the theme file

aavanzyl commented 4 years ago

I have corrected the typo, thanks for pointing it out.

Also, can you indicate if you received any errors around: it's also important to note that the variables should be set before importing the theme file

Variables should have a default value, was the issue that you could not specify any changes to the theme without having them first?

jonathan-chin commented 4 years ago

@aavanzyl my first instinct is to put all my imports at the top of the file. if you look at the styling tab for the time picker, it's clear that the import happens at the bottom of the variable definitions. however, if you look at the styling tab for the date picker, there's no import line. therefore, I assumed I should import at the top of the file.

(by the way, these two are awesome projects. I've been searching for a good date and time picker that's also easily styleable for literally years)

aavanzyl commented 4 years ago

@jonathan-chin Thanks for the input, I have updated the docs to reflect this.