aave / aave-ui

[DEPRECATED] An open source interface for the decentralized liquidity protocol Aave
https://classic.aave.com
Other
131 stars 108 forks source link

Wallet connection - list of problems #276

Closed MareskoY closed 2 years ago

MareskoY commented 2 years ago

Problem1: Steps:

  1. open app
  2. switch to polygon market
  3. open wallet connection popup

result:

Problem2: Steps:

  1. choose mainnet network
  2. open app on arbitrum market
  3. open connection popup and choose arbitrum market in the dropdown
  4. try to connect

result:

wallet-connect

sakulstra commented 2 years ago

should be fixed on latest arbitrum-clean

foodaka commented 2 years ago

@sakulstra does it include `Select preferred network- stay default and not depend on the market which user chose (in case of V3 it's kovan )``

sakulstra commented 2 years ago

@sakulstra does it include `Select preferred network- stay default and not depend on the market which user chose (in case of V3 it's kovan )``

No i initially didn't understand that point. Now i do and here's a fix for it, plz review: https://github.com/aave/aave-ui/pull/280

MareskoY commented 2 years ago

looks good

qc Passed