search

aave / aave-v3-core

This repository contains the core smart contracts of the Aave V3 protocol.
https://aave.com
Other
879 stars 573 forks source link

The _baseVariableBorrowRate" value is always added to "vars.currentVariableBorrowRate". #403

Closed foodaka closed 2 years ago

foodaka commented 2 years ago

Identified By

Scope In DefaultReserveInterestRateStrategy.sol the _baseVariableBorrowRate" value is always added to "vars.currentVariableBorrowRate". Consider just initializing the "vars.currentVariableBorrowRate" field with the "_baseVariableBorrwoRate" value.

'155            vars.currentVariableBorrowRate = 0;
178              vars.currentVariableBorrowRate =
179                _baseVariableBorrowRate +
187              vars.currentVariableBorrowRate =
188                _baseVariableBorrowRate +
foodaka commented 2 years ago

Im not sure if this was already duplicated here https://github.com/aave/aave-v3-core/issues/197

LHerskind commented 2 years ago

Im not sure if this was already duplicated here #197

How are these two issues related? One is about interest strategy and the other is PoolDataProvider