Consider adding range check for new reserve value in setReserveFactor

[foodaka]

Identified By

• ABDK

Scope

• There is not range check for the new reserve factor value in PoolConfigurator.sol.
  '247 function setReserveFactor(address asset, uint256 reserveFactor)

[LHerskind]

The setReserveFactor() from the PoolConfigurator.sol is calling ReserveConfiguration::setReserveFactor() which performs the following check:

require(reserveFactor <= MAX_VALID_RESERVE_FACTOR, Errors.RC_INVALID_RESERVE_FACTOR);

See https://github.com/aave/aave-v3-core/blob/fbe5e967b10dad1b265105eb9e7d853e832515dc/contracts/protocol/libraries/configuration/ReserveConfiguration.sol#L321

[The-3D]

I think it's worth to enforce that reserveFactor <= PercentageMath.PERCENTAGE_FACTOR. The check inReserveConfiguration only enforces that the passed value is lower or equal than the maximum that can be stored in the field

[miguelmtzinf]

Submitted #504 to address this issue