aave / aave-v3-core

This repository contains the core smart contracts of the Aave V3 protocol.
https://aave.com
Other
812 stars 538 forks source link

still issues with npm #625

Closed disestevez closed 1 year ago

disestevez commented 2 years ago

It seems that there are still issues with npm. When npm install @aave/core-v3 is executed, the console gives the following error:

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@aave%2fdeploy-v3 - Not found
npm ERR! 404 '@aave/deploy-v3@^1.17.0' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

This is further confirmed by going to the dependencies page of @aave/core-v3, found at https://www.npmjs.com/package/@aave/core-v3, which shows @aave/deploy-v3. However, https://www.npmjs.com/package/@aave/deploy-v3 gives a 404 error... :(

The-3D commented 2 years ago

The deployment npm package has not been released yet. It will be released once the protocol hits mainnet. If you need for internal testing/bug bounty, you can hit up the team and we will provide private access.

kartojal commented 2 years ago

I think this can be fixed, the @aave/deploy-v3 package is not a core dependency of @aave/core-v3 to allow uses to import interfaces, contracts or artifacts.

Will check this out.

kartojal commented 2 years ago

Somehow if I try to install normally from NPM I don't get your issue. The non-published library @aave/deploy-v3 is marked as devDependency at NPM and it should not try to install it.

You could have errors if you do npm install after you cloned this repository.

kartojal commented 2 years ago

Can you provide a reproduction environment? @disestevez

guotie commented 2 years ago

same problem

guotie commented 2 years ago

maybe this repo is private?

robertipk commented 2 years ago

I am still encountering this issue

PatrickAlphaC commented 2 years ago

I am also not sure how to install the package.

gakonst commented 2 years ago

Repro is just git clone https://github.com/aave/aave-v3-core && cd aave-v3-core && npm i

➜  aave-v3-core git:(master) npm i
npm WARN deprecated testrpc@0.0.1: testrpc has been renamed to ganache-cli, please use this package from now on.
npm WARN deprecated mkdirp-promise@5.0.1: This package is broken and no longer maintained. 'mkdirp' itself supports promises now, please switch to that.
npm WARN deprecated request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated fsevents@2.1.3: "Please update to latest v2.3 or v2.2"
npm WARN deprecated eth-sig-util@2.5.3: Deprecated in favor of '@metamask/eth-sig-util'
npm WARN deprecated debug@3.2.6: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated @ledgerhq/hw-transport-u2f@5.26.0: @ledgerhq/hw-transport-u2f is deprecated. Please use @ledgerhq/hw-transport-webusb or @ledgerhq/hw-transport-webhid. https://github.com/LedgerHQ/ledgerjs/blob/master/docs/migrate_webusb.md
npm WARN deprecated uuid@2.0.1: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated uuid@2.0.1: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated multicodec@1.0.4: This module has been superseded by the multiformats module
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated uuid@3.3.2: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated multibase@0.6.1: This module has been superseded by the multiformats module
npm WARN deprecated multibase@0.7.0: This module has been superseded by the multiformats module
npm WARN deprecated multicodec@0.5.7: This module has been superseded by the multiformats module
npm WARN deprecated axios@0.19.2: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
npm WARN deprecated axios@0.19.2: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
npm WARN deprecated cids@0.7.5: This module has been superseded by the multiformats module
npm WARN deprecated @ensdomains/ens@0.4.5: Please use @ensdomains/ens-contracts
npm WARN deprecated @ensdomains/resolver@0.2.4: Please use @ensdomains/ens-contracts
npm WARN deprecated tslint@6.1.3: TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.
npm ERR! code E401
npm ERR! Incorrect or missing password.
npm ERR! If you were trying to login, change your password, create an
npm ERR! authentication token or enable two-factor authentication then
npm ERR! that means you likely typed your password in incorrectly.
npm ERR! Please try again, or recover your password at:
npm ERR!     https://www.npmjs.com/forgot
npm ERR!
npm ERR! If you were doing some other operation then your saved credentials are
npm ERR! probably out of date. To correct this please try logging in again with:
npm ERR!     npm login

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/georgios/.npm/_logs/2022-03-24T00_42_06_822Z-debug-0.log
wepeng commented 2 years ago

@The-3D I need provide private access.Can you give me ?

WalidOfNow commented 2 years ago

The deployment npm package has not been released yet. It will be released once the protocol hits mainnet. If you need for internal testing/bug bounty, you can hit up the team and we will provide private access.

Who can i connect with for private access?

EngineEarz commented 2 years ago

ok to fix this code you need to go to your C:\Users(your user) and delete the .npmrc file

next step : npx vsts-npm-auth -config .npmrc run this line of code in terminal

hit yes , it will recreate the .npmrc file and remove authenitcation restrictions.

Liberalite commented 2 years ago

Can anyone from the Aave team give access to @aave/deploy-3 private repo? Thank you very much in advance!

RobinNagpal commented 2 years ago

Can I please get access too? Thank you very much in advance!

Tommmyklee commented 1 year ago

664 pool should be the same so it could function with no tip over

lifofernandez commented 1 year ago

Can I please get access too? Thank you very much in advance!

Hi @RobinNagpal did they grant access? I'm needing too..

miguelmtzinf commented 1 year ago

There shouldn't be any issue on installing dependencies of the repository. All packages are now available. Happy to reopen this issue if you need any help.