search

aave / interface

An open source interface for the decentralized liquidity protocol Aave
https://app.aave.com
Other
416 stars 365 forks source link

Aave alarm integration #1767

Open nebolax opened 1 year ago

nebolax commented 1 year ago

Currently on the aave interface there is a button to set up notifications with Hal project.

image

That's obviously great! But I've also made an aave-specific mobile app where you can track your addresses and receive notifications in case your health factor gets too low or you get liquidated and I think it will make sense to mention this mobile app on the website too. App repo: https://github.com/nebolax/aavealarm (it was developed thanks to a grant from aave grants dao!).

So, I am proposing an addition of some sort of a link to google play & app store on the website.

NandyBa commented 1 year ago

Assuming HAL temperature check for integration on the Aave UI good practice can be to do a similar vote.

NandyBa commented 1 year ago

@nebolax to you have Aave Alarm grey logo and hover logo as svg as public/icons/healthFactor/HAL.svg public/icons/healthFactor/HALHover.svg ?

nebolax commented 1 year ago

@nebolax to you have Aave Alarm grey logo and hover logo as svg as public/icons/healthFactor/HAL.svg public/icons/healthFactor/HALHover.svg ?

Probably not. I need to create one for the proposal, right?

NandyBa commented 1 year ago

@nebolax to you have Aave Alarm grey logo and hover logo as svg as public/icons/healthFactor/HAL.svg public/icons/healthFactor/HALHover.svg ?

Probably not. I need to create one for the proposal, right?

No it's just for integration :) to prepare UI component as curent HAL one.

https://github.com/aave/interface/assets/11545946/f694a145-7eca-4aa2-b771-4bbeb3d3ade7

NandyBa commented 1 year ago

@nebolax I let you submit the proposal you are more legit to do it.

NandyBa commented 1 year ago

Feel free to give me your feedback. If you want to test the composant you can do it by checking this branch feat/1767-add-aave-alarm-app-links

https://github.com/aave/interface/assets/11545946/b54872fe-f0b9-48d4-ac4e-ced39e450adc

Note: icon will be change to your's when given.

nebolax commented 1 year ago

Sure!! Will definitely check it out.

(but looks already great!!)