aave / interface

An open source interface for the decentralized liquidity protocol Aave
https://app.aave.com
Other
413 stars 359 forks source link

Standardize Pool approval amounts #1800

Open defispartan opened 1 year ago

defispartan commented 1 year ago

supply, repay, repayWithPermit, and supplyWithPermit are all approving underlying tokens to the Pool contract. Some approvals use a max approval while others use per-tx allowance. This should be standardized or give the option to select max approval vs per-tx.

JoaquinBattilana commented 1 year ago

Hey just to add some context to this, there are some cases that we absolutely need max approval, for example for repayWithPermit if you want to do a max repay you need to pass a signature with max approval because it validates it in the contracts