fix: token icon symbol - Githubissues

grothem commented 6 months ago

General Changes

Fixes a bug where the token icon wasn't updated on a new asset selected

Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

[ ] The base branch is set to main
[ ] The title is using Conventional Commit formatting
[ ] The Github issue has been linked to the PR in the Development section
[ ] The General Changes section has been filled out
[ ] Developer Notes have been added (optional)

If the PR is ready for review:

[ ] The PR is in Open state and not in Draft mode
[ ] The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

[ ] End-to-end tests are passing without any errors
[ ] Code style generally follows existing patterns
[ ] Code changes do not significantly increase the application bundle size
[ ] If there are new 3rd-party packages, they do not introduce potential security threats
[ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
[ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
[ ] Code changes have been quality checked in the ephemeral URL
[ ] QA verification has been completed
[ ] There are two or more approvals from the core team
[ ] Squash and merge has been checked

height[bot] commented 6 months ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

github-actions[bot] commented 6 months ago

Ipfs hash: bafybeiejmgqul3bieeqwyo6tfl7pxwofrzya7thcler64o2rrq7cuws634
Ipfs preview link: https://bafybeiejmgqul3bieeqwyo6tfl7pxwofrzya7thcler64o2rrq7cuws634.ipfs.cf-ipfs.com/

github-actions[bot] commented 6 months ago

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`537.25 KB` (-4 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/`	`78.11 KB` (🟡 +12 B)	615.36 KB
`/faucet`	`28.32 KB` (🟡 +12 B)	565.57 KB
`/governance`	`88.57 KB` (🟡 +10 B)	625.82 KB
`/history`	`36.91 KB` (🟡 +12 B)	574.16 KB
`/markets`	`29.78 KB` (🟡 +12 B)	567.03 KB
`/reserve-overview`	`24.19 KB` (🟡 +13 B)	561.44 KB
`/staking`	`24.59 KB` (🟡 +12 B)	561.84 KB
`/v3-migration`	`41.33 KB` (🟡 +12 B)	578.58 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.