Open MartinGbz opened 2 months ago
Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword
link
(e.g. "Link T-123").💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.
❌ CI run has failed! Please see logs at https://github.com/aave/interface/actions/runs/9762347615'
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Page | Size (compressed) |
---|---|
global |
539.29 KB (🟡 +1.5 KB) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
76.97 KB (🟢 -127 B) |
616.26 KB |
/faucet |
28.32 KB (🟡 +1 B) |
567.61 KB |
/governance |
88.11 KB (🟢 -487 B) |
627.4 KB |
/governance/v3/proposal |
128.38 KB (🟢 -479 B) |
667.67 KB |
/history |
36.5 KB (🟢 -422 B) |
575.79 KB |
/markets |
30.93 KB (🟢 -228 B) |
570.22 KB |
/reserve-overview |
24.19 KB (🟢 -8 B) |
563.48 KB |
/staking |
25.75 KB (🟢 -828 B) |
565.04 KB |
/v3-migration |
41.7 KB (🟢 -485 B) |
580.99 KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
❌ CI run has failed! Please see logs at https://github.com/aave/interface/actions/runs/10218562042'
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Page | Size (compressed) |
---|---|
global |
552.44 KB (🟡 +7.71 KB) |
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
73.59 KB (🟢 -212 B) |
626.03 KB |
/bridge |
44.04 KB (🟢 -553 B) |
596.48 KB |
/faucet |
23.75 KB (🟡 +2 B) |
576.18 KB |
/governance |
83.37 KB (🟢 -836 B) |
635.81 KB |
/governance/v3/proposal |
123.65 KB (🟢 -522 B) |
676.09 KB |
/history |
31.94 KB (🟢 -426 B) |
584.37 KB |
/markets |
27.03 KB (🟢 -387 B) |
579.47 KB |
/reserve-overview |
19.79 KB (🟡 +4 B) |
572.23 KB |
/staking |
21.17 KB (🟢 -833 B) |
573.61 KB |
/v3-migration |
37.5 KB (🟢 -536 B) |
589.94 KB |
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
General Changes
cbETH
that returns 0 because I didn't found any official API, so no underlying APY will be display in this case).APYs Implemented:
Developer Notes
I didn't implement the APY in the migration page because I think it's clearer to keep only Aave Supply APYs here.
For the fork mode, I set the max block range (for event logs fetching) to 1k. Because on some cases, tenderly provide RPC with only 1k max block range capacity per request. This make the fetch slower, but because it's only on fork env it's alright. For the prod mode we use 100k block as max range.
General Notes:
SupplyAssetsListMobileItem.tsx
file wasn't used because there's already aSupplyAssetsListItemMobile
component in theSupplyAssetsListItem.tsx
file. I proposed to either remove theSupplyAssetsListMobileItem.tsx
file or remove theSupplyAssetsListItemMobile
include in theSupplyAssetsListItem.tsx
file and use the one inSupplyAssetsListMobileItem.tsx
Let me know :))
Author Checklist
Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.
main
If the PR is ready for review:
Open
state and not inDraft
modeReady for Dev Review
label has been addedReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.example
file as well as the pertinant.github/actions/*
files