aave / interface

An open source interface for the decentralized liquidity protocol Aave
https://app.aave.com
Other
395 stars 335 forks source link

feat: implement aave chan interface merit claim page link [skip cypress] #2109

Closed MartinGbz closed 3 weeks ago

MartinGbz commented 1 month ago

General Changes

Based on several feedbacks from Aave users, it's not clear where to claim the rewards. This PR therefore adds a link to the official ACI Merit claim interface. Also, more clarity regarding Merit will surely be added to it, so it's important to redirect users to this frontend.

Changes:

Developer Notes


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

If the PR is ready for review:

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

height[bot] commented 1 month ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

github-actions[bot] commented 1 month ago

✅ CI run has succeded! You can find tests and deployment logs at https://github.com/aave/interface/actions/runs/9908539760'

github-actions[bot] commented 1 month ago

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 539.93 KB (🟢 -78 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 77.79 KB (🟡 +47 B) 617.71 KB
/bridge 48.85 KB (🟢 -27 B) 588.78 KB
/markets 31.42 KB (🟡 +53 B) 571.35 KB
/reserve-overview 24.19 KB (🟢 -6 B) 564.12 KB
/staking 26.51 KB (🟡 +56 B) 566.44 KB
/v3-migration 42.23 KB (🟡 +53 B) 582.16 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 month ago
github-actions[bot] commented 4 weeks ago

✅ CI run has succeded! You can find tests and deployment logs at https://github.com/aave/interface/actions/runs/10165469561'

github-actions[bot] commented 4 weeks ago

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 541.55 KB (🟢 -137 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 78.16 KB (🟡 +53 B) 619.71 KB
/bridge 49 KB (🟢 -27 B) 590.55 KB
/markets 31.9 KB (🟡 +53 B) 573.45 KB
/staking 26.66 KB (🟡 +56 B) 568.21 KB
/v3-migration 42.38 KB (🟡 +53 B) 583.93 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 4 weeks ago
github-actions[bot] commented 3 weeks ago

❌ CI run has failed! Please see logs at https://github.com/aave/interface/actions/runs/10182799751'

github-actions[bot] commented 3 weeks ago

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 544.89 KB (🟢 -137 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 73.67 KB (🟡 +53 B) 618.56 KB
/bridge 44.55 KB (🟢 -26 B) 589.45 KB
/markets 27.25 KB (🟡 +53 B) 572.14 KB
/staking 21.85 KB (🟡 +56 B) 566.74 KB
/v3-migration 37.88 KB (🟡 +53 B) 582.78 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 3 weeks ago

❌ CI run has failed! Please see logs at https://github.com/aave/interface/actions/runs/10183493953'

github-actions[bot] commented 3 weeks ago

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 544.9 KB (🟢 -128 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 73.68 KB (🟡 +63 B) 618.58 KB
/bridge 44.55 KB (🟢 -26 B) 589.46 KB
/markets 27.25 KB (🟡 +58 B) 572.15 KB
/staking 21.85 KB (🟡 +58 B) 566.75 KB
/v3-migration 37.89 KB (🟡 +58 B) 582.79 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.