search

aave / interface

An open source interface for the decentralized liquidity protocol Aave
https://app.aave.com
Other
410 stars 356 forks source link

Chore/deprecate markets #2195

Open foodaka opened 4 weeks ago

foodaka commented 4 weeks ago

General Changes

Developer Notes

Add any notes here that may be helpful for reviewers.

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

height[bot] commented 4 weeks ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

github-actions[bot] commented 4 weeks ago

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 543.36 KB (🟢 -1.38 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 64.7 KB (🟢 -708 B) 608.05 KB
/bridge 35.91 KB (🟡 +1 B) 579.26 KB
/faucet 15.1 KB (-1 B) 558.46 KB
/governance 84.17 KB (🟡 +2 B) 627.53 KB
/governance/ipfs-preview 97.58 KB (-1 B) 640.93 KB
/governance/v3/proposal 124.15 KB (🟡 +1 B) 667.5 KB
/history 23.78 KB (🟢 -19 B) 567.13 KB
/markets 26.42 KB (🟢 -615 B) 569.77 KB
/reserve-overview 19.77 KB (🟡 +2 B) 563.12 KB
/staking 21.97 KB (🟡 +3 B) 565.33 KB
/v3-migration 29.83 KB (-1 B) 573.19 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 4 weeks ago