feat: update Merit incentives to support supply and borrow incentive sides at the same time

NandyBa commented 1 week ago

…

General Changes

As some new liquidity mining (LM) programs will need to pass through Merit due to the standard LM workflow not being adapted for their asset decimals, we will very soon require Merit programs that can run in parallel—one program for the supply side and one for the borrow side. This PR addresses that need.

Developer Notes

When been implemented these change will be used to launch 3 Base LM programs (#2243)

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

[ ] End-to-end tests are passing without any errors
[ ] Code changes do not significantly increase the application bundle size
[ ] If there are new 3rd-party packages, they do not introduce potential security threats
[ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
[ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

height[bot] commented 1 week ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
interface-ez7q	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 10, 2024 5:47am

vercel[bot] commented 1 week ago

@NandyBa is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

github-actions[bot] commented 1 week ago

❌ CI run has failed! Please see logs at https://github.com/aave/interface/actions/runs/11782701771'

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`541.19 KB` (🟢 -232 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/`	`47.34 KB` (🟡 +19 B)	588.53 KB
`/bridge`	`36.01 KB` (🟢 -25 B)	577.19 KB
`/markets`	`26.87 KB` (🟡 +19 B)	568.06 KB
`/staking`	`22.84 KB` (🟡 +19 B)	564.03 KB
`/v3-migration`	`30.17 KB` (🟡 +19 B)	571.35 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

aave / interface