search

aavegotchi / aavegotchi-contracts

Aavegotchi diamond and its facets, deployment and upgrades. See the docs: https://docs.aavegotchi.com/
MIT License
310 stars 132 forks source link

Add description to itemType #22

Closed cinnabarhorse closed 3 years ago

cinnabarhorse commented 3 years ago

It's worth considering to add a description field to itemType so we can have all of the descriptions of items onchain. This would allow developers to easily replicate a marketplace later. Many NFTs have short onchain metadata.

mudgen commented 3 years ago

Also add author name of art

mudgen commented 3 years ago

I'm leery about adding these just because of the gas cost, but we can do it.

mudgen commented 3 years ago

I added author and description to itemType. These are returned by functions getItemType and getItemTypes.

The itemType.js file needs to be updated with the author and description for each itemType.

I did not add a size limit to the author and description fields because access to add items is limited to contractOwner and DAO. However we should try to limit most names and descriptions to 31 characters or less for gas savings.

cinnabarhorse commented 3 years ago

Great, this is added but probably won't be used much. Closed.