search

aavegotchi / aavegotchi-realm-diamond

23 stars 9 forks source link

Gas optimization in channelAlchemica function #8

Closed mudgen closed 2 years ago

mudgen commented 2 years ago

It would be much more gas efficient if one external function call was done to receive the two values gotten here: https://github.com/aavegotchi/aavegotchi-realm-diamond/blob/cee38d37307c49dc41cdb737a962d5d313c1cd4f/contracts/RealmDiamond/facets/AlchemicaFacet.sol#L304-L305

mudgen commented 2 years ago

@orionstardust Gas optimization looks good here. Good job.