search

aaw268 / Tea-Cozy

Second project
0 stars 0 forks source link

Overall Score #9

Open tommygebru opened 5 years ago

tommygebru commented 5 years ago 
Criteria 1: HTML Structure
Score Level: 4 - HTML implementation enables proper use of flexbox.
HTML structure mostly reflects the grouping and flow of content in the web browser.
Comment(s):  Great stuff here Ahmand, I want you to explore Semantic tags a little further

Criteria 2: Visual Layout
Score Level: 3 - Layout matches the design spec in all sections 
(This includes a sticky header w/ no gap between it and top of viewport )
Comment(s):  👍 

Criteria 3: Use of Flexbox
Score Level: 4 - Flexbox properties are correctly applied to flex containers and flex items throughout. 
Flexbox is used properly in 5+ sections and is the primary way of positioning.
Comment(s): Good stuff here as well, I want you to get more comfortable with flexbox 

Criteria 4: Implementation of Design Specification and Content
Score Level: 3 - The page includes most styles and content provided in the design specification.
(For example, anchor colors match the design spec.)
Comment(s): 👍 

Overall Score: 14/16
tommygebru commented 5 years ago

Hey Ahmand, dont worry too much about the score, it's clear you have a great understanding of HTML and CSS basics. Spend a little more time reviewing/practicing upon the feedback until it clicks, and I'm confident you'll do fine.

Also keep some HTML/CSS best practices in mind when coding https://flukeout.github.io and https://github.com/thenerdery/html-css-standards When in doubt Google it (or MDN it) 🎉

Next steps: you can update your project to include any of the suggestions I addressed today. Also if you choose to you can simply upload a new github repo, updated to reflect any feedback 👍

Ok Ahmand keep up the good work and happy coding!