aayank13 / ml4e

ML4E - Machine Learning for Everyone
https://ml4e.vercel.app
Apache License 2.0
18 stars 8 forks source link

Navbar #12

Closed AayusBhat26 closed 3 weeks ago

AayusBhat26 commented 3 weeks ago

Pull Request for ml4e šŸ’”

Requesting to submit a pull request to the PyVerse repository.


Issue Title

Please enter the title of the issue related to your pull request.
Create Navbar for ML4E Project


Info about the Related Issue

What's the goal of the project?
Describe the aim of the project.


Name

Please mention your name.
Aayush Kumar Bhat


GitHub ID

Please mention your GitHub ID.
AayusBhat26


Email ID

Please mention your email ID for further communication.
naayush448@gmail.com


Identify Yourself

Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
Web Dev


Closes

Enter the issue number that will be closed through this PR.
Closes: #7


Describe the Add-ons or Changes You've Made

Give a clear description of what you have added or modified.
1. Created a navbar 2. Managed the responsiveness of the navbar 3. Light/dark mode for home page.


Type of Change

Select the type of change:


How Has This Been Tested?

Describe how your changes have been tested.
Browser Dev Tools


Checklist

Please confirm the following:

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ā†—ļøŽ

Name Status Preview Comments Updated (UTC)
ml4e āœ… Ready (Inspect) Visit Preview šŸ’¬ Add feedback Oct 31, 2024 6:19pm
github-actions[bot] commented 3 weeks ago

šŸ‘‹ Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

aayank13 commented 3 weeks ago

@AayusBhat26 There's an issue with the themes, if I change any route then it automatically turns dark even if I had chosen light theme.

Also, the UI is not consistent with the remaining website.

AayusBhat26 commented 3 weeks ago

@AayusBhat26 There's an issue with the themes, if I change any route then it automatically turns dark even if I had chosen light theme.

Also, the UI is not consistent with the remaining website.

It was not an issue, actually, I had set the dark mode as the default theme, I didn't implemented to save the state of the theme, but now I have done that.

Below are the images large screen image

mobile screens or small screens image

aayank13 commented 3 weeks ago

@AayusBhat26 yes, it's working now. I'll merge the pull request after reviewing your code.