aayush26 / pirant

devRant API wrapper in Python
MIT License
16 stars 7 forks source link

Outdated Package on PyPi - use automated build & deploy on push to repo or cronjob #30

Open deepbrook opened 6 years ago

deepbrook commented 6 years ago

Since the current version on PyPi isn't importable (throws a hearty ImportError on calling import pirant), I suggest automating all or part of the build process.

You can check out the automated deploy process and how to set it up here: https://docs.travis-ci.com/user/deployment/pypi/

You could also, perhaps, consider a dev branch, via which you can deploy a pre-release package . If you're new to the workflow with dev branches, have a look here: http://nvie.com/posts/a-successful-git-branching-model/

For dev branch builds to work, the version number in setup.py requires the appendix d<number> or similar. See here for more on that: https://packaging.python.org/tutorials/distributing-packages/#choosing-a-versioning-scheme

This is, all of it, of course a wee bit more than necessary, but perhaps it's a neat practice excercise ? You could add issues for newbies for them to have a go at it.

aayush26 commented 6 years ago

@nlsdfnbch Thanks for opening the issue. I didn't released new version with the latest commits as I wanted to invest more time on covering more APIs and setting up stuffs before going live. The initial version in PyPi that I uploaded was just to learn how PyPi works. Also, thanks for including links to read and look further on the topics and practices you mentioned. I will be going through it.

Did you try ?

python -m pip install -U pirant

and then in Python terminal,

from pirant import DevRant

The import works fine for me.

deepbrook commented 6 years ago

That installation does work, yes. :) Glad if the links are of use to you - wasn't sure how knowledgeable you're about the whole process and didn't want to be condescending :)

aayush26 commented 6 years ago

Though, I have wrote good amount of code in python, but all for personal purpose like crawlers or classifiers/ML stuffs. Hence, never followed coding standards. This is my first time trying to build a proper python package. And hence, you can consider me as an amatuer. Feel free to share as many thoughts as you want.


Keeping this issue open to automate the pypi dev and prod deployments