search

ab-noori / Portfolio

Portfolio website will showcase all of my recent work. It will also maintain the information and history of my recent projects, the brave information about me, and the link to my resume.
https://ab-noori.github.io/Portfolio
MIT License
27 stars 0 forks source link

Peer to peer code review #11

Open torobucci opened 1 year ago

torobucci commented 1 year ago

Hi @ab-noori
Great job on applying the html and css best practices✔ I liked the way you sectioned your HTML elements and added comments. It makes it easier for a reviewer to understand your code.

I would like to address a few issues

Semantic tags

I think it would be better not to wrap the header and main tags in a div element. Semantic tags clearly indicate the role of the content they contain.

Desktop-version responsiveness

I suggest the use of percentage widths rather than fixed widths. Fixed widths make your website unresponsive. Here the wrapper div width:1440px makes it unresponsive to smaller widths.

image

ab-noori commented 1 year ago

Hi dear @torobucci,

Thank you so much for the time and effort you put to review my project 🙏 ❤️ You have done it better than every reviewer I have had 👍 You declared precisely my errors 💯

I will try my best to solve these issues.