ababaian / bioSyntax-archive

Syntax highlighting for computational biology
http://bioSyntax.org
GNU General Public License v3.0
16 stars 2 forks source link

Fixing GTF Syntax #18

Closed lazypanda10117 closed 6 years ago

lazypanda10117 commented 6 years ago

Hi all, I am trying to complete the GTF syntax and port it over to gedit. (@Ebedthan, @ababaian). As suggested in issue 14, this is near-complete, so I want to know what do I need to fix for the sublime version first, and then following that to port it over to gedit. Thank you.

ababaian commented 6 years ago

Some of my thoughts off the bat.

lazypanda10117 commented 6 years ago

Thanks! I will work on that over the weekend.

lazypanda10117 commented 6 years ago

I have just updated the GTF syntax. Is it better now?

ababaian commented 6 years ago

Can you add screenshots please?

lazypanda10117 commented 6 years ago

capture

ababaian commented 6 years ago

Nice; attributes are much clearer like this and the code is very legible, it's obvious what each component does. Care to fill out the appropriate colors for software(source) / chr.Start / chr.End and adding gradient support to the scoring? (Divide 0-1000 into 10 even segments).

lazypanda10117 commented 6 years ago

What is an appropriate color for software(source)? I have fixed the other issues except for the software color.

ababaian commented 6 years ago

Software in bioMonokai is orange italics; sorry all the different themes are not updated at the moment.

It's more about getting all the REGEX engines working (like gradient scoring) correctly and we can worry about particulars of each color and biological class last.

lazypanda10117 commented 6 years ago

capture

ababaian commented 6 years ago

Sweet looking syntax; how do you feel about giving .bed, .wig an update too?

lazypanda10117 commented 6 years ago

Sure, I will try to update them later tonight!

ababaian commented 6 years ago

Hey @lazypanda10117 ,

I was testing out the GTF syntax here on some files from different sources and it works great for cufflinks and UCSC gtf files but there's some bugs (skipped syntax) in gencode generated gtf files. That's a pretty widely used standard.

Pull the update and when you get some time can you take a look at the new examples/annot/*.gtf files I've uploaded and fix up the syntax?

ababaian commented 6 years ago

@lazypanda10117 I'm going through the gedit syntaxes and testing them and formatting the headers. The GTF syntax works really well for all the different formats. Good job!

There's a small quirk/bug in that the tabs are being selected around the feature columns and not just the word, which means if there is a background color then the selection is too wide (see below).

gtf-gedit

Can you re-format the regex to the 'robust column selection' format in gedit along the lines as syntax/gedit/faidx.lang. It'll make debugging much simpler in the future and correct the flanking tab selection issue.

Note: Make sure to pull the most recent changes to bioKate.xml for the updated color schemes.