search

ababaian / serratus

Ultra-deep search for novel viruses
http://serratus.io
GNU General Public License v3.0
251 stars 33 forks source link

How to add images to wiki/img #141

Closed rcedgar closed 4 years ago

rcedgar commented 4 years ago

@victorlin or anyone else can you please explain how to upload images to wiki/img? Can this be done without having to issue a PR? Thanks!

victorlin commented 4 years ago

Yes, I will add a wiki page with steps.

You will have to clone the wiki (it is also a git repo) and commit/push the files to the master branch. It should work if you have push access to the serratus repo.

rcedgar commented 4 years ago

Great, thanks. I think this means that updates to wiki text are immediately public, but any linked images will not be visible until a PR request is approved, did I get that right?

ababaian commented 4 years ago

PR requests are only to protect master of the main repository, it will not effect the wiki

You can push at will to your own branches of Serratus it is only the master branch that has this security feature.

rcedgar commented 4 years ago

I don't understand. What branch is the wiki on if not master? Are you saying the wiki directory does not have the same protections as the other directories so I can push without a PR, which I cannot do for src, notebook etc.? If I push an image to rce-dev, then the wiki link is broken until the PR for rce-dev is approved.

victorlin commented 4 years ago

We are talking about two repositories here:

  1. https://github.com/ababaian/serratus.git
  2. https://github.com/ababaian/serratus.wiki.git

The files in each repository are independent. PRs submitted through GitHub are only valid for the serratus repository. The serratus.wiki repository contains its own files, and modifying pages is made easy through the GitHub website. You'll have to clone and edit this repository locally to add images.

Here is a wiki page that should help: Wiki Management

rcedgar commented 4 years ago

Oh I see, thanks! Suggest linking to Wiki Management & contributing.md if not already done (I missed if so). Closing issue.