search

ababaian / serratus

Ultra-deep search for novel viruses
http://serratus.io
GNU General Public License v3.0
254 stars 33 forks source link

serratax bug when query falls outside all genera #184

Closed rcedgar closed 4 years ago

rcedgar commented 4 years ago

@rchikhi Heads up: I fixed this bug. Note that the fix short-circuits the usual version control checks and balances -- the python code is in a tarball on S3, and I uploaded a new tarball, overwriting the previous version. Bad engineering practice for sure, but I'm too new to too many things (github, docker in this case) and don't have time to learn them properly right now. It's a pretty simple fix which I doubt will break anything.

ababaian commented 4 years ago

Can you please update the copy in this main Serratus Repo so we have this version controlled for this and then Rayan can pull from there.

rchikhi commented 4 years ago

it doesn't matter much for me I already pull from https://serratus-public.s3.amazonaws.com/rce/serratax/tarball/serratax.tar.gz and this is done only when I rebuild the batch docker image

rcedgar commented 4 years ago

There is no copy in the main Serratus repo. The python code is, and always has been, in a tarball on S3 as noted above and documented here https://github.com/ababaian/serratus/blob/master/containers/serratax/README.md.

ababaian commented 4 years ago

OK we swing back to this later then. Can you rename the issue "Migrate Serratax codebase to /containers/serratax/" and we'll close it when we swing back around to this when we have time.

rcedgar commented 4 years ago

Better to open new issue because a bug fix is orthogonal to migration. Closing this one because the bug is fixed.