search

abacritt / angularx-social-login

Social login and authentication module for Angular 17
636 stars 387 forks source link

Add angular14 support #513

Closed ranma42 closed 2 years ago

ranma42 commented 2 years ago

The library seems to work just fine on Angular 14, but the peer dependencies currently forbid it. This branch updates the peer dependencies to support both 13.x and 14.x.

It is currently in draft because it relies on an alpha version of https://github.com/angular-eslint/angular-eslint/ (the 14.x version has not yet been released; according to https://github.com/angular-eslint/angular-eslint/pull/1004#issuecomment-1153620844 it should be released next weekend).

alenosmanovic91x commented 2 years ago

@ranma42 if you are not in the position to wait ( like I was not ), I have published the same library with support of angular 14 https://www.npmjs.com/package/@alenosmanovic91x/angularx-social-login

Heatmanofurioso commented 2 years ago

Hey @ranma42

I'm up to merging & deploying this PR.

Any reason for it to still be a draft?

Heatmanofurioso commented 2 years ago

Migrating this PR to https://github.com/abacritt/angularx-social-login/pull/516

Thank you @ranma42 for your help on this. Really hope you don't mind me continuing it